Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using VersionInformation explicitly #101962

Merged

Conversation

ldematte
Copy link
Contributor

@ldematte ldematte commented Nov 9, 2023

Closes #101932

@ldematte ldematte added >test Issues or PRs that are addressing/adding tests :Core/Infra/Core Core issues without another label v8.12.0 :Search/Search Search-related issues that do not fall into other categories labels Nov 9, 2023
@ldematte ldematte marked this pull request as ready for review November 9, 2023 14:36
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:Search Meta label for search team labels Nov 9, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@ldematte ldematte added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Nov 10, 2023
Copy link
Contributor

@williamrandolph williamrandolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@ldematte
Copy link
Contributor Author

Thank you William!

@ldematte ldematte merged commit 6c8e585 into elastic:main Nov 13, 2023
13 checks passed
@ldematte ldematte deleted the fix/tests/version-search-query-then-fetch-async branch November 13, 2023 08:20
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Core Core issues without another label :Search/Search Search-related issues that do not fall into other categories Team:Core/Infra Meta label for core/infra team Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] SearchQueryThenFetchAsyncActionTests testMinimumVersionSameAsNewVersion failing
3 participants