Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure deterministic in rename.DuplicateProjectEval #100473

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Oct 8, 2023

Without sort, the result can be out of order in the multi-node environment

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests auto-backport-and-merge :Analytics/ES|QL AKA ESQL v8.11.1 v8.12.0 labels Oct 8, 2023
@costin
Copy link
Member

costin commented Oct 8, 2023

Lgtm

@dnhatn dnhatn added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Oct 8, 2023
@dnhatn dnhatn marked this pull request as ready for review October 8, 2023 21:37
@elasticsearchmachine elasticsearchmachine added the Team:QL (Deprecated) Meta label for query languages team label Oct 8, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

@elasticsearchmachine elasticsearchmachine merged commit cb1e901 into elastic:main Oct 8, 2023
12 checks passed
@dnhatn dnhatn deleted the fix-duplicateProjectEval branch October 8, 2023 22:15
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Oct 8, 2023
Without sort, the result can be out of order in the multi-node
environment
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.11

elasticsearchmachine pushed a commit that referenced this pull request Oct 8, 2023
Without sort, the result can be out of order in the multi-node
environment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) Team:QL (Deprecated) Meta label for query languages team >test Issues or PRs that are addressing/adding tests v8.11.1 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants