Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release discarded pages in mutateInstance #100472

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Oct 8, 2023

./gradlew ':x-pack:plugin:esql:test' --tests "org.elasticsearch.xpack.esql.action.EsqlQueryResponseTests.testEqualsAndHashcode" -Dtests.seed=8FCFBAC8D710B529

EsqlQueryResponseTests.testEqualsAndHashcode failed on CI because we did not release pages were discarded by randomValueOtherThan while mutating the testing instance.

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests auto-backport-and-merge :Analytics/ES|QL AKA ESQL v8.11.1 v8.12.0 labels Oct 8, 2023
@dnhatn dnhatn marked this pull request as ready for review October 8, 2023 21:18
@elasticsearchmachine elasticsearchmachine added the Team:QL (Deprecated) Meta label for query languages team label Oct 8, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

@dnhatn dnhatn requested a review from nik9000 October 9, 2023 01:41
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn dnhatn merged commit db4f92f into elastic:main Oct 9, 2023
12 checks passed
@dnhatn dnhatn deleted the leak-equal branch October 9, 2023 03:42
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Oct 9, 2023
EsqlQueryResponseTests.testEqualsAndHashcode failed on CI because we did 
not release pages were discarded by randomValueOtherThan while mutating
the testing instance.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.11

elasticsearchmachine pushed a commit that referenced this pull request Oct 9, 2023
EsqlQueryResponseTests.testEqualsAndHashcode failed on CI because we did 
not release pages were discarded by randomValueOtherThan while mutating
the testing instance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL Team:QL (Deprecated) Meta label for query languages team >test Issues or PRs that are addressing/adding tests v8.11.1 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants