Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make script return value converters more ergonomic #61389

Closed
stu-elastic opened this issue Aug 20, 2020 · 2 comments
Closed

Make script return value converters more ergonomic #61389

stu-elastic opened this issue Aug 20, 2020 · 2 comments
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement Team:Core/Infra Meta label for core/infra team

Comments

@stu-elastic
Copy link
Contributor

stu-elastic commented Aug 20, 2020 •
edited
Loading

Right now, script return value converters are attached to the context, and require handling all boxed casts in the convertFromDef converter.

The converters as-is fully implement the requirements. We can make it easier for implementer by potentially pulling them out as a class and potentially call convertFromX with boxed def types rather than requiring implementers handle them.

Related: #59647
@stu-elastic stu-elastic added >enhancement :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache labels Aug 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Aug 20, 2020
@stu-elastic stu-elastic mentioned this issue Aug 20, 2020
Closed
@stu-elastic stu-elastic changed the title Make script return value converters more hygenic Make script return value converters more ergonomic Aug 20, 2020
@nik9000 nik9000 mentioned this issue Aug 25, 2020
Merged
nik9000 added a commit to nik9000/elasticsearch that referenced this issue Aug 26, 2020
@nik9000
Convert more runtime field scripts to arrays
09d988e 
This converts more runtime field scripts from the callback mechanism to
return arrays which is more compatible with aggregation scripts. Its
`instanceof`-tastic, but some of those will go away elastic#61389. Not all of
them, but some of them.
@nik9000 nik9000 mentioned this issue Aug 26, 2020
Closed
@rjernst rjernst added the needs:triage Requires assignment of a team area label label Dec 3, 2020
@jimczi jimczi removed the needs:triage Requires assignment of a team area label label Jan 12, 2021
@stu-elastic
Copy link
Contributor Author

This is not relevant anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement Team:Core/Infra Meta label for core/infra team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rjernst @elasticmachine @jimczi @stu-elastic