Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force merge with only_expunge_deletes does not honour max_num_segments #43102

Closed
ywelsch opened this issue Jun 11, 2019 · 1 comment · Fixed by #44761
Closed

Force merge with only_expunge_deletes does not honour max_num_segments #43102

ywelsch opened this issue Jun 11, 2019 · 1 comment · Fixed by #44761
Assignees
@tlrx
Labels
>bug :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard.

Comments

@ywelsch
Copy link
Contributor

ywelsch commented Jun 11, 2019

Force merge requests where only_expunge_deletes is set to true do not honour other request parameters such as max_num_segments. We should throw an exception when those two parameters are set at the same time, given that we can't do both.
@ywelsch ywelsch added >bug :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. labels Jun 11, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@dnhatn dnhatn added the help wanted adoptme label Jun 12, 2019
@tlrx tlrx self-assigned this Jul 23, 2019
@tlrx tlrx removed the help wanted adoptme label Jul 23, 2019
@tlrx tlrx mentioned this issue Jul 23, 2019
Merged
tlrx added a commit that referenced this issue Jul 26, 2019
@tlrx
Force Merge should reject requests with only_expunge_deletes and `m…
321c2b8 
…ax_num_segments` set (#44761)

This commit changes the ForceMergeRequest.validate() method so that it does 
not accept the parameters only_expunge_deletes and max_num_segments 
to be set at the same time.

The motivation is that InternalEngine.forceMerge() just ignores the max. number 
of segments parameter when the only expunge parameter is set to true, leaving 
the wrong impression to the user that max. number of segments has been applied. 
It also changes InternalEngine.forceMerge() so that it now throws an exception 
when both parameters are set, and modifies tests where needed.

Because it changes the behavior of the REST API I marked this as >breaking. 

Closes #43102
jkakavas pushed a commit that referenced this issue Jul 31, 2019
@tlrx @jkakavas
Force Merge should reject requests with only_expunge_deletes and `m…
df9b97a 
…ax_num_segments` set (#44761)

This commit changes the ForceMergeRequest.validate() method so that it does 
not accept the parameters only_expunge_deletes and max_num_segments 
to be set at the same time.

The motivation is that InternalEngine.forceMerge() just ignores the max. number 
of segments parameter when the only expunge parameter is set to true, leaving 
the wrong impression to the user that max. number of segments has been applied. 
It also changes InternalEngine.forceMerge() so that it now throws an exception 
when both parameters are set, and modifies tests where needed.

Because it changes the behavior of the REST API I marked this as >breaking. 

Closes #43102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlrx tlrx

Labels
>bug :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard.
Projects
None yet
Milestone
No milestone
4 participants
@tlrx @ywelsch @dnhatn @elasticmachine