Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] ClusterSearchShardsResponseTests.testSerialization fails reproducibly #26021

Closed
spinscale opened this issue Aug 2, 2017 · 2 comments
Closed

[CI] ClusterSearchShardsResponseTests.testSerialization fails reproducibly #26021

spinscale opened this issue Aug 2, 2017 · 2 comments
Assignees
@colings86
Labels
>test Issues or PRs that are addressing/adding tests

Comments

@spinscale
Copy link
Contributor

This test fails reproducibly on 6.x with the seed

gradle :core:test -Dtests.seed=5C8255CFDC8B4C68 -Dtests.class=org.elasticsearch.action.admin.cluster.shards.ClusterSearchShardsResponseTests -Dtests.method="testSerialization" -Dtests.security.manager=true -Dtests.locale=et-EE -Dtests.timezone=US/Pacific

CI link https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+intake/62/console

@colings86 can you take a look as the NPE stems from a querybuilder test?
@spinscale spinscale added the >test Issues or PRs that are addressing/adding tests label Aug 2, 2017
@spinscale spinscale changed the title [CI] ClusterSearchShardsResponseTests.testSerialization [CI] ClusterSearchShardsResponseTests.testSerialization fails reproducibly Aug 2, 2017
@colings86
Copy link
Contributor

@spinscale thanks for raising this, I'll look into it. Just for the record I can also reproduce this on master and I suspect the problem also exists on the 6.0 branch

@colings86 colings86 mentioned this issue Aug 2, 2017
Merged
@colings86
Copy link
Contributor

I opened #26023 to fix this

colings86 added a commit that referenced this issue Aug 2, 2017
@colings86
[TEST] fix NPE when generating random query (#26023)
aafd7f9 
`ClusterSearchShardsResponseTests.testSerialization` randomly uses `IdsQueryBuilderTests` to generate an alias filter. `IdsQueryBuilderTests` shecks if the array of current types is length zero but it can also be null which causes a `NullPointerException`. This changes adds a null check to avoid the exception.

Closes #26021
colings86 added a commit that referenced this issue Aug 2, 2017
@colings86
[TEST] fix NPE when generating random query (#26023)
00745e8 
`ClusterSearchShardsResponseTests.testSerialization` randomly uses `IdsQueryBuilderTests` to generate an alias filter. `IdsQueryBuilderTests` shecks if the array of current types is length zero but it can also be null which causes a `NullPointerException`. This changes adds a null check to avoid the exception.

Closes #26021
colings86 added a commit that referenced this issue Aug 2, 2017
@colings86
[TEST] fix NPE when generating random query (#26023)
a889f73 
`ClusterSearchShardsResponseTests.testSerialization` randomly uses `IdsQueryBuilderTests` to generate an alias filter. `IdsQueryBuilderTests` shecks if the array of current types is length zero but it can also be null which causes a `NullPointerException`. This changes adds a null check to avoid the exception.

Closes #26021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colings86 colings86

Labels
>test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colings86 @spinscale