Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] EsqlClientYamlIT test {p0=esql/70_locale/Date format with Italian locale} failing #113540

Closed
elasticsearchmachine opened this issue Sep 25, 2024 · 4 comments · Fixed by #113586
Assignees
Labels
:Analytics/ES|QL AKA ESQL needs:risk Requires assignment of a risk label (low, medium, blocker) Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Sep 25, 2024

Build Scans:

Reproduction Line:

./gradlew ":x-pack:plugin:esql:qa:server:mixed-cluster:v8.16.0#yamlRestTest" -Dtests.class="org.elasticsearch.xpack.esql.qa.mixed.EsqlClientYamlIT" -Dtests.method="test {p0=esql/70_locale/Date format with default locale}" -Dtests.seed=4FCEC800A0DA3B0C -Dtests.bwc=true -Dtests.locale=ga -Dtests.timezone=Africa/Mbabane -Druntime.java=22

Applicable branches:
main

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.lang.AssertionError: Failure at [esql/70_locale:29]: got unexpected warning header [
	299 Elasticsearch-8.16.0-f7911fedf5e5c6e5d645c45805d0d18d1dae53c8 "Date format [MMMM] contains textual field specifiers that could change in JDK 23. For more information, see https://ela.st/jdk-23-locales"
]

Issue Reasons:

  • [main] 2 consecutive failures in test test {p0=esql/70_locale/Date format with Italian locale}
  • [main] 3 consecutive failures in step 8.16.0_bwc-snapshots
  • [main] 8 failures in test test {p0=esql/70_locale/Date format with Italian locale} (0.9% fail rate in 935 executions)
  • [main] 8 failures in step 8.16.0_bwc-snapshots (2.2% fail rate in 368 executions)
  • [main] 3 failures in pipeline elasticsearch-intake (2.3% fail rate in 132 executions)
  • [main] 5 failures in pipeline elasticsearch-pull-request (1.4% fail rate in 347 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.

@elasticsearchmachine elasticsearchmachine added :Analytics/ES|QL AKA ESQL >test-failure Triaged test failures from CI labels Sep 25, 2024
elasticsearchmachine added a commit that referenced this issue Sep 25, 2024
…esql/70_locale/Date format with Italian locale} #113540
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch main

Mute Reasons:

  • [main] 5 failures in test test {p0=esql/70_locale/Date format with Italian locale} (0.5% fail rate in 929 executions)
  • [main] 5 failures in step 8.16.0_bwc-snapshots (1.4% fail rate in 364 executions)
  • [main] 2 failures in pipeline elasticsearch-intake (1.5% fail rate in 131 executions)
  • [main] 3 failures in pipeline elasticsearch-pull-request (0.9% fail rate in 346 executions)

Build Scans:

@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) needs:risk Requires assignment of a risk label (low, medium, blocker) labels Sep 25, 2024
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-analytical-engine (Team:Analytics)

@luigidellaquila luigidellaquila self-assigned this Sep 26, 2024
@luigidellaquila
Copy link
Contributor

@thecoop what's the Java 23 alternative for "MMMM" date pattern?
If any... I see we are checking the pattern [BEGOavz]|LLL|MMM|QQQ|qqq|ccc|eee|(?<!Z)Z{4}(?!Z) to identify the potentially incompatible ones, so maybe it's just a clash with "MMM"?

@thecoop
Copy link
Member

thecoop commented Sep 26, 2024

MMM deliberately also matches MMMM - its a textual date format that could change with JDK 23. It just needs to be added as an allowed warning on 8.x and 8.15, in a similar style to #113474

elasticsearchmachine pushed a commit that referenced this issue Sep 26, 2024
Fixes: #113540 Fixes:
#113539

More generic warning regex for Java 23 date patterns

(already fixed in 8.x, no need to backport)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL needs:risk Requires assignment of a risk label (low, medium, blocker) Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants