Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthetic source failure when doc_values: false #109546

Closed
salvatore-campagna opened this issue Jun 10, 2024 · 2 comments · Fixed by #112294
Closed

Synthetic source failure when doc_values: false #109546

salvatore-campagna opened this issue Jun 10, 2024 · 2 comments · Fixed by #112294

Comments

@salvatore-campagna
Copy link
Contributor

salvatore-campagna commented Jun 10, 2024

Description

All fields which support doc values have them enabled by default. Anyway, if sorting and/or aggregation and/or accessing a field from a script is not required users can disable doc values by specifying doc_values: false in index mappings.

LogsDB uses synthetic source by default and, as a result, fields without doc values cannot be reconstructed. If a field has doc_value: false and store: false in LogsDB we have to ways to deal with it:

  1. fallback to using _ignored_source so that we can reconstruct the document contents including such fields too.
  2. throw an error and require mappings not including doc_values: false
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@lkts
Copy link
Contributor

lkts commented Jun 26, 2024

This was implemented for number fields and keyword. Pretty much every other field that natively supports synthetic source won't work without doc values. This work is pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants