return immutable list

elastic · Jun 21, 2018 · d0db5e5 · d0db5e5
1 parent e647fa5
commit d0db5e5
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/server/src/main/java/org/elasticsearch/discovery/zen/UnicastZenPing.java b/server/src/main/java/org/elasticsearch/discovery/zen/UnicastZenPing.java
@@ -237,7 +237,7 @@ public static List<TransportAddress> resolveHostsLists(
                 logger.warn("timed out after [{}] resolving host [{}]", resolveTimeout, hostname);
             }
         }
-        return transportAddresses;
+        return Collections.unmodifiableList(transportAddresses);
     }
 
     @Override
@@ -280,15 +280,15 @@ public void ping(final Consumer<PingCollection> resultsConsumer, final TimeValue
     protected void ping(final Consumer<PingCollection> resultsConsumer,
                         final TimeValue scheduleDuration,
                         final TimeValue requestDuration) {
-        final List<TransportAddress> seedAddresses;
+        final List<TransportAddress> seedAddresses = new ArrayList<>();
         try {
-            seedAddresses = resolveHostsLists(
+            seedAddresses.addAll(resolveHostsLists(
                 unicastZenPingExecutorService,
                 logger,
                 configuredHosts,
                 limitPortCounts,
                 transportService,
-                resolveTimeout);
+                resolveTimeout));
         } catch (InterruptedException e) {
             throw new RuntimeException(e);
         }