Skip to content

Commit

Permalink
Ensure at least 1 seed configured in remote test (#49389)
Browse files Browse the repository at this point in the history
This fixes #49384. Currently when we select a random subset of seed
nodes from a list, it is possible for 0 seeds to be selected. This test
depends on at least 1 seed being selected.
  • Loading branch information
Tim-Brooks authored Nov 20, 2019
1 parent ddb4ae8 commit 972219f
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -461,8 +461,8 @@ public void testConnectedNodesConcurrentAccess() throws IOException, Interrupted
discoverableTransports.add(transportService);
}

List<String> seedNodes = new CopyOnWriteArrayList<>(randomSubsetOf(discoverableNodes.stream()
.map(d -> d.getAddress().toString()).collect(Collectors.toList())));
List<String> seedNodes = new CopyOnWriteArrayList<>(randomSubsetOf(randomIntBetween(1, discoverableNodes.size()),
discoverableNodes.stream().map(d -> d.getAddress().toString()).collect(Collectors.toList())));
Collections.shuffle(seedNodes, random());

try (MockTransportService service = MockTransportService.createNewService(Settings.EMPTY, Version.CURRENT, threadPool, null)) {
Expand Down

0 comments on commit 972219f

Please sign in to comment.