-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add package test to catch leaking default.data.path setting (#24029)
Adds a packaging test that would have detected #23981. The test configures path.data and validates that nothing ends up in default.path.data.
- Loading branch information
Showing
3 changed files
with
82 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 77 additions & 0 deletions
77
qa/vagrant/src/test/resources/packaging/tests/75_bad_data_paths.bats
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
#!/usr/bin/env bats | ||
|
||
# Tests data.path settings which in the past have misbehaving, leaking the | ||
# default.data.path setting into the data.path even when it doesn't belong. | ||
|
||
# WARNING: This testing file must be executed as root and can | ||
# dramatically change your system. It removes the 'elasticsearch' | ||
# user/group and also many directories. Do not execute this file | ||
# unless you know exactly what you are doing. | ||
|
||
# The test case can be executed with the Bash Automated | ||
# Testing System tool available at https://github.com/sstephenson/bats | ||
# Thanks to Sam Stephenson! | ||
|
||
# Licensed to Elasticsearch under one or more contributor | ||
# license agreements. See the NOTICE file distributed with | ||
# this work for additional information regarding copyright | ||
# ownership. Elasticsearch licenses this file to you under | ||
# the Apache License, Version 2.0 (the "License"); you may | ||
# not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
# Load test utilities | ||
load $BATS_UTILS/packages.bash | ||
load $BATS_UTILS/tar.bash | ||
load $BATS_UTILS/utils.bash | ||
|
||
@test "[BAD data.path] install package" { | ||
clean_before_test | ||
skip_not_dpkg_or_rpm | ||
install_package | ||
} | ||
|
||
@test "[BAD data.path] setup funny path.data in package install" { | ||
skip_not_dpkg_or_rpm | ||
local temp=`mktemp -d` | ||
chown elasticsearch:elasticsearch "$temp" | ||
echo "path.data: [$temp]" > "/etc/elasticsearch/elasticsearch.yml" | ||
} | ||
|
||
@test "[BAD data.path] start installed from package" { | ||
skip_not_dpkg_or_rpm | ||
start_elasticsearch_service green | ||
} | ||
|
||
@test "[BAD data.path] check for bad dir after starting from package" { | ||
skip_not_dpkg_or_rpm | ||
assert_file_not_exist /var/lib/elasticsearch/nodes | ||
} | ||
|
||
@test "[BAD data.path] install tar" { | ||
clean_before_test | ||
install_archive | ||
} | ||
|
||
@test "[BAD data.path] setup funny path.data in tar install" { | ||
local temp=`mktemp -d` | ||
chown elasticsearch:elasticsearch "$temp" | ||
echo "path.data: [$temp]" > "/tmp/elasticsearch/config/elasticsearch.yml" | ||
} | ||
|
||
@test "[BAD data.path] start installed from tar" { | ||
start_elasticsearch_service green "" "-Edefault.path.data=/tmp/elasticsearch/data" | ||
} | ||
|
||
@test "[BAD data.path] check for bad dir after starting from tar" { | ||
assert_file_not_exist "/tmp/elasticsearch/data/nodes" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters