Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][8.x] Fixes scroll helper - Backports #2557 #2558

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

picandocodigo
Copy link
Member

No description provided.

Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Fixes #2556

The iteration implementation has been fixed. There was a bug where an
additional search (with scroll) request was made to Elasticsearch for
each resulting hit. It was rewritten so that the docs are retrieved as
needed and the Helper instance doesn't store documents internally,
with big savings in memory and requests to Elasticsearch.
@picandocodigo picandocodigo merged commit 379a553 into 8.x Jan 17, 2025
12 checks passed
@picandocodigo picandocodigo deleted the fix_scroll_helper_8.x branch January 17, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant