Fix build #185
Fix build #185
Conversation
There was a problem hiding this comment.
LGTM 👍
I left a suggestion for a small typo.
Also looks like api_generator/docs/namespaces needs fleet.md and shutdown.md doc files
2021-09-06 09:40:40,074 WARN [api_generator::generator::output] Missing docs file Some("./api_generator/docs\\namespaces\\fleet.md")
2021-09-06 09:40:40,084 WARN [api_generator::generator::output] Missing docs file Some("./api_generator/docs\\namespaces\\shutdown.md")
| @@ -9,9 +9,9 @@ edition = "2018" | |||
| license = "Apache-2.0" | |||
|
|
|||
| [dependencies] | |||
| anyhow = "1.0" | |||
There was a problem hiding this comment.
Does anyhow have some clear advantages over failure?
There was a problem hiding this comment.
Failure has been deprecated and now suggests anyhow as a replacement. They are somehow similar, although I understand it anyhow uses the recent changes in the sdtlib's Error trait. But now that failure is deprecated we have to migrate away from it.
Co-authored-by: Russ Cam <russ.cam@forloop.co.uk>
| description = '''Download Rest API specs and YAML tests''' | ||
| private = true | ||
| command = "cargo" | ||
| # cargo-make insists on installing cargo-xtask and ignores .cargo/config.toml |
There was a problem hiding this comment.
@swallez you can disable it by adding:
install_crate = false
see more details at:
https://github.com/sagiegurari/cargo-make#cargo-plugins
There was a problem hiding this comment.
Thanks for the hint @sagiegurari!
This updates the build system to handle the recent changes in Elasticsearch:
Client code has also been updated to the latest 8.0.0-SNAPSHOT APIs.
The code that downloads artifacts is in a new
xtaskpackage that follows the cargo-xtasks conventions, derived from the "Make your own make" blog post. The logic to download artifacts is complex enough that it doesn't fit as a script inMake.toml, and is therefore implemented as a CLI tool that is exposed as a task inMake.toml.Note: utimately we may consider refactoring all of
Make.tomltoxtask.cargo-makeis a nice platform-independent alternative tomakebut it comes with its own weight and as the makefile grows it starts to be hard to read and navigate. Transitioning to "real code" with the help of a few crates that ease external process management may actually be more maintainable.