Support allow_duplicates on append processor #5208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Mpdreamz
requested changes
Dec 28, 2020
There was a problem hiding this comment.
I think its okay to simplify the Append cases to only run on 7.11.0 or include a AppendWithAllowDuplicates additional test class.
Easier to track then dynamically built json.
Also failing on the following CodeStandards tests:
Tests.CodeStandards.Descriptors.DescriptorMethodsTakingSingleValueTypeShouldBeNullable [FAIL]
Failed Tests.CodeStandards.Descriptors.DescriptorMethodsTakingSingleValueTypeShouldBeNullable [166 ms]
Error Message:
Expected breakingDescriptors to be empty, but found {"allowDuplicates on method AllowDuplicates of Nest.AppendProcessorDescriptor`1 is not nullable"}.
Stack Trace:
Descriptors taking value types should be nullable so that they be effectively reset.
- Fix failing test - Amend test
|
@Mpdreamz Ready for a re-review please |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 7, 2021
* Support allow_duplicates on append processor Related to elastic/elasticsearch#61916
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-master master
# Navigate to the new working tree
cd .worktrees/backport-master
# Create a new branch
git switch --create backport-5208-to-master
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 2b75c5ef1623197dc67a96d37696fcf9007438c8
# Push it to GitHub
git push --set-upstream origin backport-5208-to-master
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-masterThen, create a pull request where the |
stevejgordon
added a commit
that referenced
this pull request
Jan 7, 2021
* Support allow_duplicates on append processor Related to elastic/elasticsearch#61916 (cherry picked from commit 2b75c5e)
stevejgordon
added a commit
that referenced
this pull request
Jan 7, 2021
* Support allow_duplicates on append processor Related to elastic/elasticsearch#61916 Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon
added a commit
that referenced
this pull request
Jan 7, 2021
* Support allow_duplicates on append processor Related to elastic/elasticsearch#61916 (cherry picked from commit 2b75c5e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to elastic/elasticsearch#61916
Contributes to #5198