Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore project.lock.json files #1822

Closed
wants to merge 2 commits into from
Closed

Ignore project.lock.json files #1822

wants to merge 2 commits into from

Conversation

gmarz
Copy link
Contributor

@gmarz gmarz commented Feb 10, 2016

I know there are good reasons to check in project.lock.json, but the official stance is to not. It makes merging a PITA and adds noise to diffs.

Thoughts @Mpdreamz @russcam ?

@gmarz gmarz added the Vote label Feb 10, 2016
@Romanx
Copy link
Contributor

Romanx commented Feb 12, 2016

I'd add a 👍 to this as it's a pain working locally with them updating on you and having to ignore them if you git add -p

@Mpdreamz
Copy link
Member

project.lock.json really needs to separate its concerns, since we are never ever going to use floating dependencies we could possibly decide to not check these in.

But only because nuget resolves transient dependencies to lowest (which is a horrible default), unless ofcourse someone's machine has overriden this in a nuget.config at a machine/user profile level using

<add key="DependencyVersion" value="Highest" />

Then our build can possibly be broken on their machine and they'd never know why, repeatable builds are lost if we pull this one.

I'm +1 for pulling this one in though since I'm still holding my breath for either paket and dotnet-cli playing nice or atleast aspnet/dnx#2322 landing before the whole toolchain GA's

@Mpdreamz
Copy link
Member

@gmarz mind rebasing against master?

@russcam
Copy link
Contributor

russcam commented Feb 16, 2016

Happy to keep them out of commits and reduce the noise 👍

@Mpdreamz Mpdreamz closed this in 3deddcb Feb 19, 2016
@Mpdreamz Mpdreamz deleted the fix/ignore-lock-files branch February 19, 2016 16:06
@Mpdreamz
Copy link
Member

Added this in 3deddcb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants