Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diff target #3305

Closed
russcam opened this issue Jun 26, 2018 · 0 comments
Closed

Improve diff target #3305

russcam opened this issue Jun 26, 2018 · 0 comments
Assignees
@russcam

Comments

@russcam
Copy link
Contributor

russcam commented Jun 26, 2018 •
edited
Loading

The diff target is able to diff

  • assemblies: two assemblies
  • directories: pairs of assemblies
  • github: the output of two github commits
  • nuget: the lib and its dependencies

The implementation does not currently handle

  • Finding the nearest target framework match in dependent nuget packages (this functionality is exposed in Nuget.Frameworks)
  • Ability to diff locally compiled current state against a nuget/github
  • Diff'ing IL merged NEST assemblies (it does not error, but the output fails to pick up appropriate changes).

Improvements should be made to address these issues.
@russcam russcam self-assigned this Sep 3, 2018
russcam added a commit to elastic/elasticsearch-net-abstractions that referenced this issue Sep 5, 2018
@russcam
Port Differ to console application
ee6d607 
This commit ports the Differ F# script over to a console
application, and includes a number of improvements:

- Correct resolution of NuGet references respective to target framework
- Ability to diff any two assembly providers e.g.
    compare NuGet package to the build of a GitHub commit
    compare loacl assembly to NuGet package, etc.

Closes elastic/elasticsearch-net#3305
@russcam russcam mentioned this issue Sep 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@russcam russcam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@russcam