-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for shortcut properties of non-primitive type #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-trotta
approved these changes
Aug 20, 2024
java-client/src/test/java/co/elastic/clients/elasticsearch/model/BehaviorsTest.java
Outdated
Show resolved
Hide resolved
java-client/src/test/java/co/elastic/clients/elasticsearch/model/UnionTests.java
Outdated
Show resolved
Hide resolved
…el/BehaviorsTest.java Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
…el/UnionTests.java Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-858-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 1217de03eaf8bb7e8eaaa65762abdc3a3de23d4b
# Push it to GitHub
git push --set-upstream origin backport-858-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.15 8.15
# Navigate to the new working tree
cd .worktrees/backport-8.15
# Create a new branch
git switch --create backport-858-to-8.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 1217de03eaf8bb7e8eaaa65762abdc3a3de23d4b
# Push it to GitHub
git push --set-upstream origin backport-858-to-8.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.15 Then, create a pull request where the |
l-trotta
added a commit
that referenced
this pull request
Aug 22, 2024
Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
l-trotta
added a commit
that referenced
this pull request
Aug 22, 2024
Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional parameter to
ObjectDeserializer.shortcutProperty
to indicate if the shortcut property if of primitive type or not.If it's not a primitive type shortcut, we look ahead in the JSON stream to see if the shortcut property exist. If it doesn't then this is a shortcut, and otherwise this is the normal shape of the object.