Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Add 7.17.3 to conditional attributes #248

Merged
merged 1 commit into from
Apr 21, 2022
Merged

[DOCS] Add 7.17.3 to conditional attributes #248

merged 1 commit into from
Apr 21, 2022

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 21, 2022

This PR addresses the following documentation build errors:

11:24:06 INFO:build_docs:ERROR building Java Client version 7.17
...
11:24:06 INFO:build_docs:
11:24:06 INFO:build_docs:asciidoctor: WARNING: invalid reference: loading-json
11:24:06 INFO:build_docs:
11:24:06 INFO:build_docs:Child exited with 255 at lib/ES/Util.pm line 666.

@lcawl lcawl marked this pull request as ready for review April 21, 2022 19:01
@lcawl lcawl requested a review from swallez April 21, 2022 19:01
@lcawl lcawl mentioned this pull request Apr 21, 2022
Merged
philkra
philkra approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit 0074c80 into elastic:7.17 Apr 21, 2022
@lcawl lcawl deleted the 7173-eval branch April 21, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philkra philkra philkra approved these changes

@swallez swallez Awaiting requested review from swallez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcawl @philkra