Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to installation doc with helidon framework notes #227

Closed
wants to merge 2 commits into from

Conversation

ksurendra
Copy link

Added notes mentioning that the dependency jakarta.json:jakarta.json-api:2.0.1 needs to be explicitly added to projects built with other frameworks like Helidon and not only Spring Boot.

Else users will see the same exception at runtime: java.lang.ClassNotFoundException: jakarta.json.spi.JsonProvider.

@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
1a35f6c

Please, read and sign the above mentioned agreement if you want to contribute to this project

@ksurendra
Copy link
Author

❌ Author of the following commits did not sign a Contributor Agreement: 1a35f6c

Please, read and sign the above mentioned agreement if you want to contribute to this project

Completed doc sign on 3/30/2022

@swallez
Copy link
Member

swallez commented Apr 14, 2022

@ksurendra for my understanding, can you explain what happens in Helidon without the dependency added? Is it forced into a different version as with the Spring plugin? Does it lead to ClassNotFoundException?

@ksurendra
Copy link
Author

ksurendra commented Apr 14, 2022

@ksurendra for my understanding, can you explain what happens in Helidon without the dependency added? Is it forced into a different version as with the Spring plugin? Does it lead to ClassNotFoundException?

@swallez without the dependency users will see a ClassNotFoundException exception at runtime.
To be precise this one: java.lang.ClassNotFoundException: jakarta.json.spi.JsonProvider

@swallez
Copy link
Member

swallez commented Apr 14, 2022

Ok, thanks. This looks like the exact same problem as with Spring.

The CLA check still fails. Did you use the same GitHub account when signing it? If yes, I'll reach out to our infra team to understand why it keeps failing.

@ksurendra
Copy link
Author

Ok, thanks. This looks like the exact same problem as with Spring.

The CLA check still fails. Did you use the same GitHub account when signing it? If yes, I'll reach out to our infra team to understand why it keeps failing.

Thanks. The issue is similar, just wanted to add the wording so it does not look like only "spring" has it.
think I used the same username, anyways re-signed the CLA again.

@swallez
Copy link
Member

swallez commented May 2, 2022

@ksurendra the docs have been heavily restructured, and I also refactored the installation document to explain this issue in a more framework-independent way while still mentioning Spring Boot and Helidon.

I will therefore close this PR, which has been superseded by PR #265 (and has been published on the website). Thanks for the heads up about Helidon!

@swallez swallez closed this May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants