Fix serialization of NaN/Infinite/Min/Max values (#223)

elastic · Mar 30, 2022 · 33cdf3a · 33cdf3a
1 parent f682657
commit 33cdf3a
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 4 deletions.
diff --git a/java-client/src/main/java/co/elastic/clients/json/JsonpUtils.java b/java-client/src/main/java/co/elastic/clients/json/JsonpUtils.java
@@ -217,17 +217,15 @@ public static String toString(JsonValue value) {
     }
 
     public static void serializeDoubleOrNull(JsonGenerator generator, double value, double defaultValue) {
-        // Only output null if the default value isn't finite, which cannot be represented as JSON
-        if (value == defaultValue && !Double.isFinite(defaultValue)) {
+        if (!Double.isFinite(value)) {
             generator.writeNull();
         } else {
             generator.write(value);
         }
     }
 
     public static void serializeIntOrNull(JsonGenerator generator, int value, int defaultValue) {
-        // Only output null if the default value isn't finite, which cannot be represented as JSON
-        if (value == defaultValue && defaultValue == Integer.MAX_VALUE || defaultValue == Integer.MIN_VALUE) {
+        if (value == defaultValue && (defaultValue == Integer.MAX_VALUE || defaultValue == Integer.MIN_VALUE)) {
             generator.writeNull();
         } else {
             generator.write(value);

diff --git a/java-client/src/test/java/co/elastic/clients/elasticsearch/json/JsonpUtilsTest.java b/java-client/src/test/java/co/elastic/clients/elasticsearch/json/JsonpUtilsTest.java
@@ -23,12 +23,15 @@
 import co.elastic.clients.util.AllowForbiddenApis;
 import jakarta.json.JsonException;
 import jakarta.json.spi.JsonProvider;
+import jakarta.json.stream.JsonGenerator;
 import org.junit.Assert;
 import org.junit.Test;
 
+import java.io.StringWriter;
 import java.net.URL;
 import java.util.Collections;
 import java.util.Enumeration;
+import java.util.function.Consumer;
 
 public class JsonpUtilsTest extends Assert {
 
@@ -60,4 +63,52 @@ public Enumeration<URL> getResources(String name) {
             Thread.currentThread().setContextClassLoader(savedLoader);
         }
     }
+
+    @Test
+    public void testSerializeDoubleOrNull() {
+        // ---- Double values
+        assertEquals("{\"a\":null}", orNullHelper(g -> JsonpUtils.serializeDoubleOrNull(g, Double.NaN, Double.NaN)));
+        assertEquals("{\"a\":1.0}", orNullHelper(g -> JsonpUtils.serializeDoubleOrNull(g, 1.0, Double.NaN)));
+
+        assertEquals("{\"a\":null}",
+            orNullHelper(g -> JsonpUtils.serializeDoubleOrNull(g, Double.POSITIVE_INFINITY, Double.POSITIVE_INFINITY)));
+        assertEquals("{\"a\":1.0}", orNullHelper(g -> JsonpUtils.serializeDoubleOrNull(g, 1.0, Double.POSITIVE_INFINITY)));
+
+        assertEquals("{\"a\":null}",
+            orNullHelper(g -> JsonpUtils.serializeDoubleOrNull(g, Double.POSITIVE_INFINITY, Double.POSITIVE_INFINITY)));
+        assertEquals("{\"a\":1.0}", orNullHelper(g -> JsonpUtils.serializeDoubleOrNull(g, 1.0, Double.NEGATIVE_INFINITY)));
+
+        assertEquals("{\"a\":null}", orNullHelper(g -> JsonpUtils.serializeDoubleOrNull(g, Double.NaN, 0.0)));
+
+        // Serialize defined default values
+        assertEquals("{\"a\":0.0}", orNullHelper(g -> JsonpUtils.serializeDoubleOrNull(g, 0.0, 0.0)));
+
+    }
+
+    @Test
+    public void testSerializeIntOrNull() {
+        assertEquals("{\"a\":null}", orNullHelper(g -> JsonpUtils.serializeIntOrNull(g, Integer.MAX_VALUE, Integer.MAX_VALUE)));
+        assertEquals("{\"a\":1}", orNullHelper(g -> JsonpUtils.serializeIntOrNull(g, 1, Integer.MAX_VALUE)));
+        assertEquals("{\"a\":1}", orNullHelper(g -> JsonpUtils.serializeIntOrNull(g, 1, 0)));
+
+        // Integer.MAX_VALUE is valid if not the default value
+        assertEquals("{\"a\":2147483647}", orNullHelper(g -> JsonpUtils.serializeIntOrNull(g, Integer.MAX_VALUE, 0)));
+        assertEquals("{\"a\":2147483647}", orNullHelper(g -> JsonpUtils.serializeIntOrNull(g, Integer.MAX_VALUE, Integer.MIN_VALUE)));
+
+        // Serialize non infinite default values
+        assertEquals("{\"a\":0}", orNullHelper(g -> JsonpUtils.serializeIntOrNull(g, 0, 0)));
+    }
+
+    private static String orNullHelper(Consumer<JsonGenerator> c) {
+        StringWriter sw = new StringWriter();
+        JsonGenerator generator = JsonpUtils.provider().createGenerator(sw);
+
+        generator.writeStartObject();
+        generator.writeKey("a");
+        c.accept(generator);
+        generator.writeEnd();
+        generator.close();
+
+        return sw.toString();
+    }
 }