remove DSL code and redirect imports to unified Python client #1968
+24
−21,370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgrinberg
force-pushed
the
dsl-import-redirect
branch
from
92942ea to
41d4dce
Compare
miguelgrinberg
force-pushed
the
dsl-import-redirect
branch
from
e2c1a6d to
f6cac5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all the code from the Elasticsearch DSL library and replaces it with redirects to the same code now located in the Python client (https://github.com/elastic/elasticsearch-py).
I'm leaving the unit tests untouched, to confirm that the import redirects work well.
Must be merged after the unified client is released. Until then, to avoid failures the dependency on the Python client was changed to install the main branch.