Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export async_connections at the package level #1865

Merged
merged 1 commit into from
Jul 30, 2024
Merged

export async_connections at the package level #1865

merged 1 commit into from
Jul 30, 2024

Conversation

miguelgrinberg
Copy link
Collaborator

The async_connections module was missing as a top-level package export.

@miguelgrinberg miguelgrinberg added the Category: Bug Something isn't right label Jul 20, 2024
@miguelgrinberg miguelgrinberg requested a review from pquentin July 29, 2024 11:22
pquentin
pquentin approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@miguelgrinberg miguelgrinberg added the backport 8.x Backport to 8.x label Jul 30, 2024
@miguelgrinberg miguelgrinberg merged commit d5679d0 into elastic:main Jul 30, 2024
18 checks passed
@miguelgrinberg miguelgrinberg deleted the add-async-connections branch July 30, 2024 12:53
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
@miguelgrinberg @github-actions
export async_connections at the package level (#1865)
895e60a 
(cherry picked from commit d5679d0)
@github-actions github-actions bot mentioned this pull request Jul 30, 2024
Merged
miguelgrinberg added a commit that referenced this pull request Jul 30, 2024
@github-actions @miguelgrinberg
export async_connections at the package level (#1865) (#1869)
386e4f8 
(cherry picked from commit d5679d0)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
backport 8.x Backport to 8.x Category: Bug Something isn't right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguelgrinberg @pquentin