Added error checking for unsupported minimum_should_match values #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgrinberg
force-pushed
the
unsupported-min-should-match
branch
from
f41ecc6 to
1fa8bc5
Compare
miguelgrinberg
force-pushed
the
unsupported-min-should-match
branch
from
1fa8bc5 to
c33c543
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
(cherry picked from commit c650b62)
miguelgrinberg
added a commit
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small improvement regarding #1451, so that the error message provides guidance on what's wrong. The developer can then decide if it makes sense to rewrite the terms using a positive minimum_should_match, or create a combined expression manually.