Fix importing collapse from dict #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
requested changes
Dec 22, 2023
| @@ -294,7 +294,6 @@ def _clone(self): | |||
| s = self.__class__( | |||
| using=self._using, index=self._index, doc_type=self._doc_type | |||
| ) | |||
| s._collapse = self._collapse.copy() | |||
There was a problem hiding this comment.
Great catch, thanks! Can you please move self._collapse = {} to Search.__init__ too?
There was a problem hiding this comment.
the Search class already initializes self._collapse. The one in Request should not be there, I'm removing it.
miguelgrinberg
force-pushed
the
collapse-bugs
branch
from
4cb2a24 to
0fd40f9
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Dec 22, 2023
(cherry picked from commit f0c5045)
pquentin
pushed a commit
that referenced
this pull request
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor bugs in the
collapseimplementation:collapsekey was inRequestinstead ofSearchcollapsekey was not importing from dict