Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(area_charts): correctly represent baseline with negative data points [23.x] #903

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Nov 12, 2020

Backports the following commits to 23.x:

fix(area_charts): correctly represent baseline with negative data points (#896)

@markov00 markov00 changed the base branch from master to 23.x November 12, 2020 13:32
@codecov-io
Copy link

codecov-io commented Nov 12, 2020

Codecov Report

Merging #903 (5d42de5) into 23.x (46f1bd7) will increase coverage by 0.60%.
The diff coverage is 90.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##             23.x     #903      +/-   ##
==========================================
+ Coverage   70.01%   70.61%   +0.60%     
==========================================
  Files         321      336      +15     
  Lines       10508    10816     +308     
  Branches     2221     2185      -36     
==========================================
+ Hits         7357     7638     +281     
- Misses       3142     3163      +21     
- Partials        9       15       +6     
Flag Coverage Δ
unittests 70.11% <89.74%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/scales/scale_continuous.ts 95.97% <77.77%> (-1.92%) ⬇️
src/chart_types/xy_chart/rendering/rendering.ts 93.97% <93.22%> (+0.68%) ⬆️
src/mocks/series/utils.ts 100.00% <100.00%> (ø)
src/scales/constants.ts 100.00% <100.00%> (ø)
src/mocks/series/series.ts 88.13% <0.00%> (ø)
src/mocks/theme.ts 100.00% <0.00%> (ø)
src/mocks/series/data.ts 100.00% <0.00%> (ø)
src/mocks/store/store.ts 92.59% <0.00%> (ø)
src/mocks/store/index.ts 100.00% <0.00%> (ø)
src/mocks/specs/index.ts 100.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46f1bd7...5d42de5. Read the comment docs.

@markov00
Copy link
Member Author

jenkins test this please

@markov00 markov00 merged commit 5f240d1 into elastic:23.x Nov 12, 2020
@markov00 markov00 deleted the 2020_11_12-fix_negative_values branch November 12, 2020 14:43
markov00 pushed a commit that referenced this pull request Nov 12, 2020
## [23.2.2](v23.2.1...v23.2.2) (2020-11-12)

### Bug Fixes

* **area_charts:** correctly represent baseline with negative data points ([#903](#903)) ([5f240d1](5f240d1))
@markov00
Copy link
Member Author

🎉 This PR is included in version 23.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants