Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build/type issue with DataGenerator #671

Merged
merged 1 commit into from
May 8, 2020

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented May 8, 2020

Summary

Bug caused by DataGenerator Class now expecting a random number generator. Broke EUI docs.

  • Move around types to exclude mocks directory
  • Remove import of seedrandom from dist files
  • Add default rng function for DataGenerator

We should move pallettes.ts out of mocks/ all prevent any src code in this directory, might be best to move it to the root folder or in a testing utils root directory.

Checklist

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • This was checked for cross-browser compatibility, including a check against IE11

- Move around types to exclude mocks directory
- Remove import of seedrandom from dist files
- Add default rng function for DataGenerator
@nickofthyme nickofthyme added the bug Something isn't working label May 8, 2020
@nickofthyme nickofthyme requested a review from markov00 May 8, 2020 02:39
@codecov-io
Copy link

codecov-io commented May 8, 2020

Codecov Report

Merging #671 into master will decrease coverage by 0.05%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
- Coverage   72.97%   72.91%   -0.06%     
==========================================
  Files         266      266              
  Lines        8634     8641       +7     
  Branches     1698     1700       +2     
==========================================
  Hits         6301     6301              
- Misses       2294     2301       +7     
  Partials       39       39              
Impacted Files Coverage Δ
...hart_types/partition_chart/layout/config/config.ts 68.75% <ø> (ø)
...types/partition_chart/layout/types/config_types.ts 100.00% <ø> (ø)
...rtition_chart/layout/viewmodel/link_text_layout.ts 19.04% <0.00%> (ø)
src/utils/data_generators/simple_noise.ts 100.00% <ø> (ø)
src/utils/data_generators/data_generator.ts 44.44% <22.22%> (-10.73%) ⬇️
...ypes/partition_chart/layout/viewmodel/viewmodel.ts 89.23% <100.00%> (ø)
src/mocks/utils.ts 94.11% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7166e42...bc8f7c8. Read the comment docs.

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickofthyme nickofthyme merged commit 86dd2b1 into elastic:master May 8, 2020
@nickofthyme nickofthyme deleted the fix/data-generator branch May 8, 2020 14:01
markov00 pushed a commit that referenced this pull request May 8, 2020
# [19.3.0](v19.2.0...v19.3.0) (2020-05-08)

### Bug Fixes

* build/type issue with DataGenerator ([#671](#671)) ([86dd2b1](86dd2b1))

### Features

* **partition:** linked text maximum length config ([#665](#665)) ([7166e42](7166e42))
@markov00
Copy link
Member

markov00 commented May 8, 2020

🎉 This PR is included in version 19.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label May 8, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
# [19.3.0](elastic/elastic-charts@v19.2.0...v19.3.0) (2020-05-08)

### Bug Fixes

* build/type issue with DataGenerator ([opensearch-project#671](elastic/elastic-charts#671)) ([01844ac](elastic/elastic-charts@01844ac))

### Features

* **partition:** linked text maximum length config ([opensearch-project#665](elastic/elastic-charts#665)) ([e37cb8f](elastic/elastic-charts@e37cb8f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants