-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: treemap / sunburst / pie / donut charts #493
Conversation
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 75.15% 75.36% +0.21%
==========================================
Files 192 192
Lines 5744 5769 +25
Branches 1062 1114 +52
==========================================
+ Hits 4317 4348 +31
+ Misses 1411 1405 -6
Partials 16 16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise looks good to me.
I've added few comments on coding conventions that should be addressed and some one more important related to missing exported types.
We have to add snapshot tests. I can do that in a different PR
Some failed CI runs due to cancelled runs and not checking in |
# [16.2.0](v16.1.0...v16.2.0) (2020-01-21) ### Features * implement treemap, sunburst, pie and donut charts ([#493](#493)) ([e4de627](e4de627))
🎉 This PR is included in version 16.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [16.2.0](elastic/elastic-charts@v16.1.0...v16.2.0) (2020-01-21) ### Features * implement treemap, sunburst, pie and donut charts ([opensearch-project#493](elastic/elastic-charts#493)) ([41a1133](elastic/elastic-charts@41a1133))
Summary
1st round of hierarchical, partitioning visualizations. Fixes #84 including #381 (comment)
Other related issues: #381 #464 #492
Treemap:
Sunburst:
Donut:
Mid-transition from possible future tweening:
Features we can lift:
GROUP BY ROLLUP
)Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts
(and stories only import from../src
except for test data & storybook)