Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(axis): log scale limit and base options #1032

Merged
merged 32 commits into from
Feb 18, 2021
Merged

feat(axis): log scale limit and base options #1032

merged 32 commits into from
Feb 18, 2021

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Feb 17, 2021 •
edited
Loading

Summary

closes #916

The main features added in this PR are the following:

  • Set base of log scales to 10, 2 or e (Common, Binary or Natural), via domain.logBase and xDomain.logBase
  • Set custom min limit of log values, previously hardcoded to 1, via domain.logMinLimit
  • Allow domain to fit full domain of dataset, without crossing 0 via domain.fit option

logMinLimit

Screen Recording 2021-02-04 at 01 16 PM

No logMinLimit set, uses full domain

Screen Recording 2021-02-04 at 01 17 PM

yLogBase

Screen Recording 2021-02-04 at 01 18 PM

Checklist

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios

@nickofthyme
feat(scales): log scale improvements and options
4a91ad8 
- Set base of log scales to 10, 2 or e
- Set custom min limit of log values, previously hardcoded to 1
- Allow domain to fit full domain of dataset, without crossing 0
@nickofthyme
chore: tighten Domain and Range types per x and y
42ce439
@nickofthyme
fix: broken unit tests and types
7ef4e53
@nickofthyme
WIP
d6dcfec
@nickofthyme
Merge branch 'master' into log-options
d9c6125
@nickofthyme
fix: mixed polarity, area baseline, add vrt, improve tick formatter
ea7868c
@nickofthyme
test: revert original to args, fix new args
af1c983
@nickofthyme
fix: upgrade api extractor and fix type issues
52f1e0d
@nickofthyme
fix: export LogBase type from top
ada219d
@nickofthyme
test: add tests for log changes
c8066f5 
- test all limitLogScaleDomain variations
- prevent negative domain padding
@nickofthyme
Merge branch 'master' into log-options
dc3459f
@nickofthyme
Merge branch 'master' into log-options
c0f2bde
@nickofthyme
test: update vrt screenshot
fc4eee4
@nickofthyme
Merge branch 'master' into log-options
1a8d6f6
@nickofthyme
fix: x domain scale issue, refactor log options
a26fd2c 
- move all log options together
- fix x domain being different across other xScale getters
- update log option wording
@nickofthyme
Merge branch 'master' into log-options
9999d8b
@nickofthyme
fix: rename options and update api.md
019c3a4
@nickofthyme
refactor: make log options per axis
9b9bce1
@nickofthyme
refactor: remove x domain log limit, make default limit 1
4737a84
@nickofthyme
test: update vrt for scales and areas based on changes
1054511
@nickofthyme
chore: cleanup old and outdated screenshots
749186b
@nickofthyme nickofthyme added :axis Axis related issue :data Data/series/scales related issue enhancement New feature or request labels Feb 17, 2021
markov00
markov00 reviewed Feb 18, 2021
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few VRTs to fix and also some unit test to refactor with the new implementation (in particular the ones using computeContinuousDataDomain

integration/tests/scales_stories.test.ts Outdated Show resolved Hide resolved
src/chart_types/xy_chart/domains/types.ts Show resolved Hide resolved
src/chart_types/xy_chart/utils/axis_utils.test.ts Outdated Show resolved Hide resolved
src/chart_types/xy_chart/utils/scales.ts Outdated Show resolved Hide resolved
src/chart_types/xy_chart/utils/specs.ts Show resolved Hide resolved
src/scales/scale_continuous.ts Show resolved Hide resolved
src/scales/scale_continuous.ts Outdated Show resolved Hide resolved
src/chart_types/xy_chart/utils/scales.ts Outdated Show resolved Hide resolved
src/scales/scale_continuous.ts Outdated Show resolved Hide resolved
src/chart_types/xy_chart/utils/axis_utils.ts Outdated Show resolved Hide resolved
markov00
markov00 approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge for me.
If you want, you can go back with the previous api-extractor version and remove the last remaining named tuple ContinuousDomain to clean up the API report

@nickofthyme nickofthyme merged commit b38d110 into elastic:master Feb 18, 2021
@nickofthyme nickofthyme deleted the log-options branch February 18, 2021 23:04
@nickofthyme nickofthyme mentioned this pull request Mar 1, 2021
Closed
github-actions bot pushed a commit that referenced this pull request Mar 1, 2021
@semantic-release-bot
chore(release): 25.1.0 [skip ci]
85b6ed3 
# [25.1.0](v25.0.1...v25.1.0) (2021-03-01)

### Bug Fixes

* rounding values on stacked w percentage charts ([#1039](#1039)) ([ee63a70](ee63a70))

### Features

* **axis:** log scale limit and base options ([#1032](#1032)) ([b38d110](b38d110))
* **partition:** clip text in partition chart fill label ([#1033](#1033)) ([be9bea0](be9bea0))
@markov00
Copy link
Member

markov00 commented Mar 1, 2021

🎉 This PR is included in version 25.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Mar 1, 2021
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 25.1.0 [skip ci]
cad8263 
# [25.1.0](elastic/elastic-charts@v25.0.1...v25.1.0) (2021-03-01)

### Bug Fixes

* rounding values on stacked w percentage charts ([opensearch-project#1039](elastic/elastic-charts#1039)) ([021e836](elastic/elastic-charts@021e836))

### Features

* **axis:** log scale limit and base options ([#1032](elastic/elastic-charts#1032)) ([11f94c6](elastic/elastic-charts@11f94c6))
* **partition:** clip text in partition chart fill label ([opensearch-project#1033](elastic/elastic-charts#1033)) ([7626441](elastic/elastic-charts@7626441))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

Assignees
No one assigned
Labels
:axis Axis related issue :data Data/series/scales related issue enhancement New feature or request released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto min value on log scale
2 participants
@nickofthyme @markov00