feat(axis): log scale improvements and options #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
added
enhancement
nickofthyme
changed the title
- Set base of log scales to 10, 2 or e - Set custom min limit of log values, previously hardcoded to 1 - Allow domain to fit full domain of dataset, without crossing 0
nickofthyme
force-pushed
the
log-options
branch
from
1b72af4
to
7ef4e53
Compare
nickofthyme
commented
Feb 8, 2021
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| import { $Values } from 'utility-types'; | |||
| import { ComponentType } from 'react'; | |||
| import React from 'react'; | |||
| import { default as React_2 } from 'react'; | |||
There was a problem hiding this comment.
This usually happens when you are using JSX without importing React or when importing react as import * from React but I've checked your PR and it doesn't seem to touch anything like that. I will investigate on it a bit
- test all limitLogScaleDomain variations - prevent negative domain padding
Codecov Report
@@ Coverage Diff @@
## master #1014 +/- ##
==========================================
- Coverage 72.78% 72.73% -0.05%
==========================================
Files 363 363
Lines 11211 11217 +6
Branches 2434 2447 +13
==========================================
- Hits 8160 8159 -1
- Misses 3037 3044 +7
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
markov00
reviewed
Feb 16, 2021
api/charts.api.md
Outdated
Comment on lines
1957
to
1960
| xLogBase: LogBase; | ||
| xLogMinLimit?: number; | ||
| yLogBase: LogBase; | ||
| yLogMinLimit?: number; |
There was a problem hiding this comment.
We can have multiple Y axis and "ideally" multiple yLogBase
what if we move these option within the Axis and/or within the xDomain props?
let's discuss it
There was a problem hiding this comment.
OK see a26fd2c
- move all log options together - fix x domain being different across other xScale getters - update log option wording
github-actions bot
pushed a commit
that referenced
this pull request
Feb 16, 2021
# [25.0.0](v24.6.0...v25.0.0) (2021-02-16) ### Bug Fixes * group legend items by label and color ([#999](#999)) ([5d32f23](5d32f23)) ### Features * **axis:** log scale improvements and options ([#1014](#1014)) ([0f52688](0f52688)) ### BREAKING CHANGES * The `LegendActionProps` and the `LegendColorPickerProps`, used to add actions and color picker through the legend now receive an array of `SeriesIdentifiers`
|
🎉 This PR is included in version 25.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
nickofthyme
added a commit
that referenced
this pull request
Feb 17, 2021
This reverts commit 0f52688.
nickofthyme
added a commit
that referenced
this pull request
Feb 17, 2021
This reverts commit 0f52688.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2021
## [25.0.1](v25.0.0...v25.0.1) (2021-02-17) ### Reverts * log scale improvements and options ([#1014](#1014)) ([2189f92](2189f92))
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [25.0.0](elastic/elastic-charts@v24.6.0...v25.0.0) (2021-02-16) ### Bug Fixes * group legend items by label and color ([opensearch-project#999](elastic/elastic-charts#999)) ([ce0bfba](elastic/elastic-charts@ce0bfba)) ### Features * **axis:** log scale improvements and options ([opensearch-project#1014](elastic/elastic-charts#1014)) ([8bac5e8](elastic/elastic-charts@8bac5e8)) ### BREAKING CHANGES * The `LegendActionProps` and the `LegendColorPickerProps`, used to add actions and color picker through the legend now receive an array of `SeriesIdentifiers`
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [25.0.1](elastic/elastic-charts@v25.0.0...v25.0.1) (2021-02-17) ### Reverts * log scale improvements and options ([opensearch-project#1014](elastic/elastic-charts#1014)) ([7aa1ce7](elastic/elastic-charts@7aa1ce7))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #916
The main features added in this PR are the following:
Common,BinaryorNatural)yMinLimitNo
yMinLimitset, uses full domainyLogBaseChecklist
src/index.ts(and stories only import from../srcexcept for test data & storybook)