Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibana CI complains about elastic-charts dependencies on xpack #145

Closed
markov00 opened this issue Apr 2, 2019 · 1 comment · Fixed by #146
Closed

Kibana CI complains about elastic-charts dependencies on xpack #145

markov00 opened this issue Apr 2, 2019 · 1 comment · Fixed by #146
Assignees
Labels
bug Something isn't working released Issue released publicly

Comments

@markov00
Copy link
Member

markov00 commented Apr 2, 2019

Describe the bug
We have two different WIP PRs that integrates elastc-charts into Kibana that reports a red CI with the following error during the intake:

22:21:19 ERROR x-pack failed
22:21:19       ../node_modules/@elastic/charts/dist/lib/series/curves.d.ts:13:72 - error TS7016: Could not find a declaration file for module 'd3-shape'. '/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-intake/node/immutable/kibana/node_modules/@elastic/charts/node_modules/d3-shape/dist/d3-shape.js' implicitly has an 'any' type.
22:21:19         If the 'd3-shape' package actually exposes this module, consider sending a pull request to amend 'https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/d3-shape`
22:21:19 
22:21:19       13 export declare function getCurveFactory(curveType?: CurveType): import("d3-shape").CurveFactory;
22:21:19                                                                                 ~~~~~~~~~~
22:21:19 
22:21:19       ../node_modules/@elastic/charts/dist/utils/data/formatters.d.ts:1:26 - error TS7016: Could not find a declaration file for module 'luxon'. '/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-intake/node/immutable/kibana/node_modules/luxon/build/node/luxon.js' implicitly has an 'any' type.
22:21:19         Try `npm install @types/luxon` if it exists or add a new declaration (.d.ts) file containing `declare module 'luxon';`
22:21:19 
22:21:19       1 import { Interval } from 'luxon';
22:21:19                                  ~~~~~~~
22:21:19 
22:21:19 
22:21:19       Found 2 errors.

Failing PRs:

@markov00 markov00 added the bug Something isn't working label Apr 2, 2019
@markov00 markov00 added this to the 7.1 milestone Apr 2, 2019
@markov00 markov00 self-assigned this Apr 2, 2019
markov00 pushed a commit that referenced this issue Apr 2, 2019
## [3.5.1](v3.5.0...v3.5.1) (2019-04-02)

### Bug Fixes

* **build:** fix dependencies for kibana integration ([#146](#146)) ([b875e3d](b875e3d)), closes [#145](#145)
@markov00
Copy link
Member Author

markov00 commented Apr 2, 2019

🎉 This issue has been resolved in version 3.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Apr 2, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Issue released publicly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant