Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0](backport #6611) Integration tests: Parse agent version from version.go #6842

Merged
merged 1 commit into from
Feb 14, 2025
Merged

[9.0](backport #6611) Integration tests: Parse agent version from version.go #6842

merged 1 commit into from
Feb 14, 2025
+15 −9

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 13, 2025

What does this PR do?

The way how we defined the agent version for integration tests wasn't reliable. It works correctly on the main branch but might work incorrectly on 8.17. That blocks the backports to 8.17 and 8.16. The new approach parses version.go.

  • Modified integration test scripts
  • The regexes will be replaced and simplified when this issue is done

Why is it important?

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...
This is an automatic backport of pull request #6611 done by [Mergify](https://mergify.com).

@pazone @mergify
Integration tests: Parse agent version from version.go (#6611)
6b48016 
* Integration tests: use the mage target to get agent version

* Added snapshot to version

* Test run

* Test run Windows

* Removed -v flag

* Parse agent version

* Cleanup

(cherry picked from commit cab384c)
@mergify mergify bot requested a review from a team as a code owner February 13, 2025 10:01
@mergify mergify bot added the backport label Feb 13, 2025
@mergify mergify bot assigned pazone Feb 13, 2025
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@oakrizan oakrizan merged commit 75f0d6f into 9.0 Feb 14, 2025
16 checks passed
@oakrizan oakrizan deleted the mergify/bp/9.0/pr-6611 branch February 14, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oakrizan oakrizan oakrizan approved these changes

Assignees

@pazone pazone

Labels
backport enhancement New feature or request skip-changelog Team:Ingest-EngProd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oakrizan @pazone