[8.16](backport #5831) Use a PodTemplate resource in the Helm Chart #5930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
added
backport
conflicts
mergify
bot
requested review from
pkoutsovasilis and
michel-laterman
and removed request for
a team
|
Cherry-pick of f891fb0 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
7 tasks
* Use PodTemplate resource in the Helm Chart * Remove unnecessary named template * Use PodTemplate resource in the Helm Chart for ECK (cherry picked from commit f891fb0) # Conflicts: # deploy/helm/elastic-agent/examples/eck/rendered/manifest.yaml # deploy/helm/elastic-agent/examples/kubernetes-default/rendered/manifest.yaml # deploy/helm/elastic-agent/examples/kubernetes-hints-autodiscover/rendered/manifest.yaml # deploy/helm/elastic-agent/examples/kubernetes-only-logs/rendered/manifest.yaml # deploy/helm/elastic-agent/examples/multiple-integrations/rendered/manifest.yaml # deploy/helm/elastic-agent/examples/nginx-custom-integration/rendered/manifest.yaml # deploy/helm/elastic-agent/examples/system-custom-auth-paths/rendered/manifest.yaml
swiatekm
force-pushed
the
mergify/bp/8.16/pr-5831
branch
from
66672bb to
dde8dc5
Compare
swiatekm
approved these changes
Nov 5, 2024
|
pierrehilbert
added
the
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Instead of an untyped .tpl Helm template, use a PodTemplate resource. This resource is loaded from a file, templated via the tpl function, converted to a dict to get a specific key, and then converted back to YAML.
This is a bit convoluted, but it gives us intellisense for the pod template.
Why is it important?
.tpl files aren't very readable. On the other hand, Kubernetes resources get pretty good support from IDEs and tools. So this is a maintainability improvement.
Checklist
This is an automatic backport of pull request #5831 done by [Mergify](https://mergify.com).