[helm] support using user-created serviceAccount and clusterRole #5593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkoutsovasilis
force-pushed
the
pkoutsovasilis/helm_service_account
branch
from
1f67a7d to
6567ef6
Compare
|
This pull request does not have a backport label. Could you fix it @pkoutsovasilis? 🙏
|
|
|
mergify
bot
added
the
backport-8.x
|
pkoutsovasilis
changed the title
7 tasks
pkoutsovasilis
changed the title
pkoutsovasilis
force-pushed
the
pkoutsovasilis/helm_service_account
branch
2 times, most recently
from
7aa5a6e to
bdb81d0
Compare
pierrehilbert
added
the
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
pkoutsovasilis
force-pushed
the
pkoutsovasilis/helm_service_account
branch
from
19ae4ec to
6668f5a
Compare
swiatekm
reviewed
Nov 6, 2024
pkoutsovasilis
force-pushed
the
pkoutsovasilis/helm_service_account
branch
from
8ce3bbf to
d5b7191
Compare
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
* feat: support using user-created serviceAccount and clusterRole * feat: add support for defining automountServiceAccountToken per preset * fix: add preset-wide annotations to serviceaccount, clusterrole, clusterrolebinding (cherry picked from commit 5ac225d)
mergify bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
* feat: support using user-created serviceAccount and clusterRole * feat: add support for defining automountServiceAccountToken per preset * fix: add preset-wide annotations to serviceaccount, clusterrole, clusterrolebinding (cherry picked from commit 5ac225d)
This was referenced Nov 8, 2024
Merged
pkoutsovasilis
added a commit
that referenced
this pull request
Nov 8, 2024
…t and clusterRole (#5977) * [helm] support using user-created serviceAccount and clusterRole (#5593) * feat: support using user-created serviceAccount and clusterRole * feat: add support for defining automountServiceAccountToken per preset * fix: add preset-wide annotations to serviceaccount, clusterrole, clusterrolebinding (cherry picked from commit 5ac225d) * fix: render helm chart examples --------- Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
pkoutsovasilis
added a commit
that referenced
this pull request
Nov 8, 2024
…nt and clusterRole (#5976) * [helm] support using user-created serviceAccount and clusterRole (#5593) * feat: support using user-created serviceAccount and clusterRole * feat: add support for defining automountServiceAccountToken per preset * fix: add preset-wide annotations to serviceaccount, clusterrole, clusterrolebinding (cherry picked from commit 5ac225d) * fix: render helm chart examples --------- Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces the capability for users to bind agent presets with custom service accounts and cluster roles, rather than relying solely on auto-generated or default configurations. This allows greater control over security and permissions for agent interactions. Additionally, it provides support for adding annotations to these bindings, allowing for custom metadata that can be leveraged by observability and monitoring tools to enhance tracking, auditing, and configuration management.
Why is it important?
This added flexibility ensures that the Helm chart can be better aligned with organizational policies and infrastructure requirements of users.
Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
N/A
How to test this PR locally
Related issues
automountServiceAccountTokenfor each preset which by setting it to false a user can effectively disable kubernetes provider completely