Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shutdown logs #87

Merged
merged 5 commits into from
Oct 26, 2022
Merged

Conversation

AndersonQ
Copy link
Member

@AndersonQ AndersonQ commented Oct 26, 2022

What does this PR do?

Improve logs when handling shutdown.

Why is it important?

Often we investigate problems which one of the symptom is the Elastic Agent or beats restarting. However often it's uncertain what is making the agent to shutdown.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Related issues

@AndersonQ AndersonQ added enhancement New feature or request 8.6-candidate labels Oct 26, 2022
@AndersonQ AndersonQ requested a review from a team as a code owner October 26, 2022 12:49
@AndersonQ AndersonQ self-assigned this Oct 26, 2022
@AndersonQ AndersonQ requested review from fearful-symmetry and faec and removed request for a team October 26, 2022 12:49
@AndersonQ AndersonQ changed the title improve shutdown logs Improve shutdown logs Oct 26, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 26, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-26T20:55:14.371+0000

  • Duration: 10 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 723
Skipped 5
Total 728

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@@ -38,7 +38,7 @@ import (

// HandleSignals manages OS signals that ask the service/daemon to stop.
// The stopFunction should break the loop in the Beat so that
// the service shut downs gracefully.
// the service shutdowns gracefully.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shutdowns -> "shuts down"

@AndersonQ AndersonQ merged commit fb82de1 into elastic:main Oct 26, 2022
@AndersonQ AndersonQ deleted the 1358-better-shutdown-logs branch October 26, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.6-candidate enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants