-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve shutdown logs #87
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersonQ
requested review from
fearful-symmetry and
faec
and removed request for
a team
October 26, 2022 12:49
belimawr
approved these changes
Oct 26, 2022
faec
approved these changes
Oct 26, 2022
service/service.go
Outdated
@@ -38,7 +38,7 @@ import ( | |||
|
|||
// HandleSignals manages OS signals that ask the service/daemon to stop. | |||
// The stopFunction should break the loop in the Beat so that | |||
// the service shut downs gracefully. | |||
// the service shutdowns gracefully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shutdowns -> "shuts down"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve logs when handling shutdown.
Why is it important?
Often we investigate problems which one of the symptom is the Elastic Agent or beats restarting. However often it's uncertain what is making the agent to shutdown.
Checklist
- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.md
Related issues