certutil: add functional options #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersonQ
added
the
Team:Elastic-Agent-Control-Plane
AndersonQ
requested review from
belimawr and
rdner
and removed request for
a team
This was referenced Oct 16, 2024
add functional options to New*RootCA and Generate*ChildCert to allow setting a prefix for the CN and multiple DNS names
AndersonQ
force-pushed
the
certutil-add-opts-func
branch
from
1656938
to
cdacf83
Compare
belimawr
reviewed
Oct 16, 2024
testing/certutil/certutil.go
Outdated
| func GenerateChildCert(name string, ips []net.IP, caPrivKey crypto.PrivateKey, caCert *x509.Certificate, opts ...Option) (*tls.Certificate, Pair, error) { | ||
| priv, err := ecdsa.GenerateKey(elliptic.P384(), rand.Reader) | ||
| if err != nil { | ||
| return nil, Pair{}, fmt.Errorf("could not create RSA private key: %w", err) |
There was a problem hiding this comment.
You're calling ecdsa.GenerateKey, it looks like a typo in the error message:
Suggested change
| return nil, Pair{}, fmt.Errorf("could not create RSA private key: %w", err) | |
| return nil, Pair{}, fmt.Errorf("could not create ECDSA private key: %w", err) |
| opts...) | ||
| if err != nil { | ||
| return nil, Pair{}, fmt.Errorf( | ||
| "could not generate child TLS certificate CA: %w", err) |
There was a problem hiding this comment.
Why is the 'CA' at the end of this error message? I believe "could not generate child TLS certificate: %w" would be enough.
Suggested change
| "could not generate child TLS certificate CA: %w", err) | |
| "could not generate child TLS certificate: %w", err) |
💚 Build Succeeded
History
cc @AndersonQ |
belimawr
approved these changes
Oct 16, 2024
AndersonQ
added a commit
to AndersonQ/elastic-agent-libs
that referenced
this pull request
Oct 23, 2024
add functional options to New*RootCA and Generate*ChildCert to allow setting a prefix for the CN and multiple DNS names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add functional options to NewRootCA and GenerateChildCert to allow setting a prefix for the CN and multiple DNS names.
Also, it fixes
GenerateChildCertgenerating a RSA instead of EC certificateWhy is it important?
Checklist
[ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist