Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop hashstructure dependency #223

Merged
merged 4 commits into from
Aug 24, 2024

Conversation

kruskall
Copy link
Member

What does this PR do?

drop hashstructure dependency
we are only using the library to hash a slice of strings, implement the logic in a custom method and drop the library

Why is it important?

hashstructure was archived and it is no longer maintained

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

Related issues

hashstructure was archived and it is no longer maintained
we are only using the library to hash a slice of strings,
implement the logic in a custom method and drop the library
@kruskall kruskall requested a review from a team as a code owner August 10, 2024 20:35
@kruskall kruskall requested review from AndersonQ and belimawr and removed request for a team August 10, 2024 20:35
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Aug 11, 2024
@AndersonQ
Copy link
Member

Could you add a test? O think a test for hash where the it uses the same value to produce 2 hashed and check if they're the same should be enough.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@kruskall kruskall merged commit 8c7c5ca into elastic:main Aug 24, 2024
6 checks passed
@kruskall kruskall deleted the refactor/drop-hashstructure branch August 24, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants