Add NewWithConfig init function to api/server.go #192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds a new init method,
NewWithConfig
, that takes aConfig
struct, and not aconfig.C
blob.Why is it important?
As part of elastic/elastic-agent#4499 I'm refactoring the server setup process so the monitoring server can properly be reloaded by agent. I need this to clean up the init process, since agent will needlessly turn the Config struct into a config blob so it can pass it to
New
.Checklist