Remove obsolete "Treating the CommonName field on X.509 certificates as a host name..." warning #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmacknz
requested review from
ycombinator and
fearful-symmetry
and removed request for
a team
cmacknz
force-pushed
the
remove-obsolete-deprecation
branch
from
b2c5bcb
to
4e3bc71
Compare
💚 Build Succeeded
History
cc @cmacknz |
cmacknz
changed the title
belimawr
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an unconditional warning for "Treating the CommonName field on X.509 certificates as a host name when no Subject Alternative Names are present is going to be removed."
This deprecation was done in Go 1.15.0 and we are many releases past 8.0.0. This warning can now be removed, it is just adding log noise.