Update TLS certificates in tests #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belimawr
added
bug
belimawr
requested review from
rdner and
fearful-symmetry
and removed request for
a team
belimawr
force-pushed
the
fix-tls-certs
branch
from
8228833
to
66c31d7
Compare
Some TLS certificates used in tests expired, this commit fixes it by generating the certificates and, if needed, calculating the fingerprint on each test. This will prevent future CI failures and reduce the maintenance burden.
belimawr
force-pushed
the
fix-tls-certs
branch
from
66c31d7
to
2edaf34
Compare
blakerouse
approved these changes
Dec 19, 2023
leehinman
previously requested changes
Dec 19, 2023
| } | ||
|
|
||
| // If for any reason there is a need to debug |
There was a problem hiding this comment.
If for some reason this fails in CI, we are going to want the cert/key pair to see what happened. How about always dumping out the keys & certs, then deleting the dir if the test succeeds?
There was a problem hiding this comment.
Yeah, I first thought about it, but while writing this PR what helped me was to have a fixed set of certs that I could use over multiple test runs. So I ended up generating them once and re-using until I found out where the mismatch between cert, CA and fingerprint were.
Anyway, I see no issue in persisting them on failure.
|
All suggestions implemented on 9d031ae |
belimawr
force-pushed
the
fix-tls-certs
branch
from
9d031ae
to
793de7e
Compare
💚 Build Succeeded
History
cc @belimawr |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some TLS certificates used in tests expired, this commit fixes it by generating the certificates and, if needed, calculating the fingerprint on each test.
This will prevent future CI failures and reduce the maintenance burden.
Why is it important?
It fixes the broken tests
Checklist
- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.md## Author's Checklist## Related issues