-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kibana client API wrappers for tamper protection E2E support #141
Add kibana client API wrappers for tamper protection E2E support #141
Conversation
|
||
// https://www.elastic.co/guide/en/fleet/8.8/fleet-apis.html#createPackagePolicy | ||
// request https://www.elastic.co/guide/en/fleet/8.8/fleet-apis.html#package_policy_request | ||
type PackagePolicyRequest struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Is https://github.com/elastic/elastic-agent/blob/main/pkg/testing/tools/fleet_package_policy_api.go getting removed when this merges?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, saw the "TODO" there and addressed along with other new additions that were needed for agent tampering test cases. Will pull these from the library once it merges and update agent E2E tests.
What does this PR do?
Add kibana client API wrappers for tamper protection E2E support
is_protected
property toAgentPolicyUpdateRequest
. This allows to enabled and disabled tamper protection through the policy update Kibana APIGetPolicyUninstallTokens
, that allows to to fetch uninstall tokens for tamper protected policy.DeleteFleetPackage
. Is needed for testing of Endpoint tamper protection E2E.InstallFleetPackage
from https://github.com/elastic/elastic-agent/blob/main/pkg/testing/tools/fleet_package_policy_api.go#L66. Addresses that TODO item.Was not sure if the current integration tests are ran in CI, but it was convenient to have some coverage and tests the APIs.
Why is it important?
These new additions are needed for Agent/Endpoint tamper protection E2E tests.
Checklist
CHANGELOG.md