Deal with the mad aggregation being removed in Pandas 2 #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartbroere
changed the title
bartbroere
changed the title
|
buildkite test this please |
pquentin
requested changes
Oct 11, 2023
Done! Sorry about that. |
|
@pquentin the PR build seems to have hung how can I restart it? |
|
buildkite test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas 2 has removed the
madaggregation. To be able to test whether eland's version produces the correct result, we can implement it ourselves, just for the tests.Of course I'm open to other ideas (skipping the metric if we are in Pandas 2 perhaps?).
Related pandas issue: pandas-dev/pandas#11787
Related to #601