Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove event.dataset from integration with elastic-apm #69

Merged
merged 3 commits into from
Oct 14, 2021

Conversation

basepi
Copy link
Contributor

@basepi basepi commented Oct 14, 2021

Also removes python 3.5 support as we now test against elastic-apm @ master which doesn't support python 3.5.

Ref elastic/apm-agent-python#1365

@basepi basepi self-assigned this Oct 14, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Oct 14, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-14T17:26:41.574+0000

  • Duration: 8 min 31 sec

  • Commit: 4622cdc

Test stats 🧪

Test Results
Failed 0
Passed 162
Skipped 0
Total 162

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@basepi
Copy link
Contributor Author

basepi commented Oct 14, 2021

/test

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Validating dropping Python 3.5 by looking at our PyPI stats, we've received 0-1 downloads from Python 3.5 for the past while. Goodbye Python 3.5!

@basepi basepi merged commit b83dedb into elastic:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants