Skip to content

Commit

Permalink
[CI] Always test against elastic-apm @ master (#68)
Browse files Browse the repository at this point in the history
* Revert "[CI]: trigger build after apm-agent-python@master build finished and test it with the master branch (#64)"

This reverts commit 9f35b52.

* Always install elastic-apm from master for development/testing
  • Loading branch information
basepi authored Oct 14, 2021
1 parent 9951e76 commit fca42f1
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 18 deletions.
3 changes: 0 additions & 3 deletions .ci/Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ pipeline {
issueCommentTrigger("${obltGitHubComments()}")
// Only master branch will run on a timer basis
cron(env.BRANCH_NAME == 'master' ? '@daily' : '')
// enable upstream trigger for the master branch only
upstream("/apm-agent-python/apm-agent-python-mbp/${ env.JOB_BASE_NAME.equals('master') ? 'master' : 'none' }")
}
stages {
stage('Checkout') {
Expand All @@ -34,7 +32,6 @@ pipeline {
deleteDir()
gitCheckout(basedir: "${BASE_DIR}", githubNotifyFirstTimeContributor: true)
stash allowEmpty: true, name: 'source', useDefaultExcludes: false
setEnvVar('ELASTIC_AGENT_PYTHON_BRANCH', isUpstreamTrigger(filter: 'apm-agent-python-mbp/master') ? 'master' : 'default')
}
}
stage('Lint') {
Expand Down
7 changes: 0 additions & 7 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,13 @@
# under the License.

import nox
import os


SOURCE_FILES = ("noxfile.py", "tests/", "ecs_logging/")


def tests_impl(session):
session.install(".[develop]")
session.install(
".[{0}]".format(
os.environ.get("ELASTIC_AGENT_PYTHON_BRANCH", "default").lower()
)
)

session.run(
"pytest",
"--junitxml=junit-test.xml",
Expand Down
9 changes: 1 addition & 8 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,7 @@ develop = [
"pytest-cov",
"mock",
"structlog",
]

default = [
"elastic-apm",
]

master = [
'elastic-apm @ https://github.com/elastic/apm-agent-python/archive/master.zip',
"elastic-apm @ https://github.com/elastic/apm-agent-python/archive/master.zip",
]

[tool.flit.metadata.urls]
Expand Down

0 comments on commit fca42f1

Please sign in to comment.