Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .log suffix from default event.dataset #95

Closed
trentm opened this issue Aug 30, 2021 · 0 comments · Fixed by #150
Closed

Remove .log suffix from default event.dataset #95

trentm opened this issue Aug 30, 2021 · 0 comments · Fixed by #150
Labels
agent-nodejs Make available for APM Agents project planning.
Milestone
8.0

Comments

@trentm
Copy link
Member

trentm commented Aug 30, 2021

Implement elastic/ecs-logging#63 for the nodejs ecs-logging libs.
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Aug 30, 2021
@trentm trentm mentioned this issue Aug 30, 2021
Merged
@AlexanderWert AlexanderWert added this to the 8.0 milestone Oct 18, 2021
trentm added a commit that referenced this issue Oct 14, 2023
@trentm
chore: prefer dotted field names; drop ".log" suffix on event.dataset
deb97b9 
- Change to adding dotted field names (`"ecs.version": "1.6.0"`), rather than
  namespaced fields (`"ecs": {"version": "1.6.0"}`) for most fields. This is
  supported by the ecs-logging spec, and arguably preferred in the ECS logging
  docs. It is also what the ecs-logging-java libraries do. The resulting output
  is slightly shorter, and accidental collisions with user fields is less
  likely.
- Stop adding ".log" suffix to `event.dataset` field.

Closes: #95
trentm added a commit that referenced this issue Oct 14, 2023
@trentm
chore: prefer dotted field names; drop ".log" suffix on event.dataset
1f67743 
- Change to adding dotted field names (`"ecs.version": "1.6.0"`), rather than
  namespaced fields (`"ecs": {"version": "1.6.0"}`) for most fields. This is
  supported by the ecs-logging spec, and arguably preferred in the ECS logging
  docs. It is also what the ecs-logging-java libraries do. The resulting output
  is slightly shorter, and accidental collisions with user fields is less
  likely.
- Stop adding ".log" suffix to `event.dataset` field.

Closes: #95
@trentm trentm mentioned this issue Oct 14, 2023
Merged
trentm added a commit that referenced this issue Oct 16, 2023
@trentm
chore: prefer dotted field names; drop ".log" suffix on `event.datase…
80a4b22 
…t` (#150)

- Change to adding dotted field names (`"ecs.version": "1.6.0"`), rather than
  namespaced fields (`"ecs": {"version": "1.6.0"}`) for most fields. This is
  supported by the ecs-logging spec, and arguably preferred in the ECS logging
  docs. It is also what the ecs-logging-java libraries do. The resulting output
  is slightly shorter, and accidental collisions with user fields is less
  likely.
- Stop adding ".log" suffix to `event.dataset` field.

Closes: #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
APM-Agents (OLD)
Status: Done
Milestone
8.0
Development

Successfully merging a pull request may close this issue.

chore: prefer dotted field names; drop ".log" suffix on event.dataset elastic/ecs-logging-nodejs
2 participants
@trentm @AlexanderWert