Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: double underscore in case uppercase character is preceeded by an underscore #190

Merged
merged 8 commits into from
Aug 22, 2022
Merged

Fix: double underscore in case uppercase character is preceeded by an underscore #190

merged 8 commits into from
Aug 22, 2022

Conversation

andreycha
Copy link
Contributor

Problem
Currently property like User_Id is serialized as user__id (note double underscore).

Changes

  • Fix to produce only one underscore
  • Add tests for snake case

@cla-checker-service
Copy link

cla-checker-service bot commented Jul 21, 2022

💚 CLA has been signed

@apmmachine
Copy link
Contributor

apmmachine commented Jul 21, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-22T06:58:08.470+0000

  • Duration: 14 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 84
Skipped 0
Total 84

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for catching this @andreycha ! Waiting to sort out the CLA before merging.

Can you retarget this PR to the main branch?

@andreycha andreycha changed the base branch from 1.6 to main July 29, 2022 12:27
@andreycha
Copy link
Contributor Author

andreycha commented Jul 29, 2022

Done.

Probably it's worth marking somewhere that once dotnet/runtime#782 is released (seems to be part of .NET 8) custom naming policy can be dropped.

@Mpdreamz Mpdreamz added bug Something isn't working v8.5.0 v8.4.0 and removed v8.5.0 labels Aug 22, 2022
@Mpdreamz Mpdreamz merged commit 89bb8f0 into elastic:main Aug 22, 2022
@andreycha andreycha deleted the fix/underscore-and-uppercase-in-snake-case-naming-policy branch August 27, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants