-
Notifications
You must be signed in to change notification settings - Fork 42
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
elastic/helm-charts#964 introduced the feature of deploying a Kubernetes deployment instead of a Daemonset using Filebeat, using a values.yaml syntax equivalent to Metricbeat
@@ -362,7 +362,7 @@ func (ts *HelmChartTestSuite) getResourceName(resource string) string { | |||
} else if resource == k8s.ResourceTypes.ClusterRoleBinding { | |||
return strings.ToLower(ts.Name + "-" + ts.Name + "-cluster-role-binding") | |||
} else if resource == k8s.ResourceTypes.ConfigMap { | |||
if ts.Name == "metricbeat" { | |||
if ts.Name == "filebeat" || ts.Name == "metricbeat" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmlrt I checked that filebeat is now deployed as daemonset. With this change now we are covering that case, and the tests pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM⛴
.ci/Jenkinsfile
Outdated
string(name: 'HELM_CHART_VERSION', defaultValue: '7.10.0', description: 'SemVer version of Helm chart to be used.') | ||
string(name: 'HELM_VERSION', defaultValue: '3.4.1', description: 'SemVer version of Helm to be used.') | ||
string(name: 'HELM_KIND_VERSION', defaultValue: '0.8.1', description: 'SemVer version of Kind to be used.') | ||
string(name: 'HELM_CHART_VERSION', defaultValue: '7.11.1', description: 'SemVer version of Helm chart to be used.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7.11.2 has been released last week
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, let's update this PR then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM⛴
* chore: bump helm charts version * chore: bump helm version * chore: bump kind version * fix: support filebeat deployment elastic/helm-charts#964 introduced the feature of deploying a Kubernetes deployment instead of a Daemonset using Filebeat, using a values.yaml syntax equivalent to Metricbeat * chore: update version to 7.11.2 # Conflicts: # .ci/Jenkinsfile
* chore: bump helm charts version * chore: bump helm version * chore: bump kind version * fix: support filebeat deployment elastic/helm-charts#964 introduced the feature of deploying a Kubernetes deployment instead of a Daemonset using Filebeat, using a values.yaml syntax equivalent to Metricbeat * chore: update version to 7.11.2 # Conflicts: # .ci/Jenkinsfile
* chore: bump helm charts version * chore: bump helm version * chore: bump kind version * fix: support filebeat deployment elastic/helm-charts#964 introduced the feature of deploying a Kubernetes deployment instead of a Daemonset using Filebeat, using a values.yaml syntax equivalent to Metricbeat * chore: update version to 7.11.2 # Conflicts: # .ci/Jenkinsfile
* chore: bump helm charts version * chore: bump helm version * chore: bump kind version * fix: support filebeat deployment elastic/helm-charts#964 introduced the feature of deploying a Kubernetes deployment instead of a Daemonset using Filebeat, using a values.yaml syntax equivalent to Metricbeat * chore: update version to 7.11.2 # Conflicts: # .ci/Jenkinsfile
* chore: bump helm charts version * chore: bump helm version * chore: bump kind version * fix: support filebeat deployment elastic/helm-charts#964 introduced the feature of deploying a Kubernetes deployment instead of a Daemonset using Filebeat, using a values.yaml syntax equivalent to Metricbeat * chore: update version to 7.11.2 # Conflicts: # .ci/Jenkinsfile
* chore: bump helm charts version * chore: bump helm version * chore: bump kind version * fix: support filebeat deployment elastic/helm-charts#964 introduced the feature of deploying a Kubernetes deployment instead of a Daemonset using Filebeat, using a values.yaml syntax equivalent to Metricbeat * chore: update version to 7.11.2 # Conflicts: # .ci/Jenkinsfile
…hings * upstream/master: fix: generate a jUnit file per test suite (elastic#907) chore: rename slack channel for Fleet's nightly build (elastic#899) chore: do not scan 6.8.x branch (elastic#879) chore: bump helm versions (elastic#874)
What does this PR do?
It bumps versions for Helm test suite:
We also found that filebeat uses a daemonset for deployment, exactly as metricbeat does. We updated the code that calculated the resource name to match the new behaviour. For further information, please see the original PR that added that change.
Why is it important?
Test latest versions
Checklist
make notice
in the proper directory)Author's Checklist
How to test this PR locally
SUITE="helm" DEVELOPER_MODE=false TIMEOUT_FACTOR=1 LOG_LEVEL=TRACE ELASTIC_APM_ACTIVE=true make -C e2e functional-test
Related issues