-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud account refinement #284
base: main
Are you sure you want to change the base?
Conversation
you're right. I'm not sure how the nav will be built, but long term it won't all be appearing in the left hand side like this - instead, I think a custom top nav will be built and things will manually need to be added to it (rather than having it be auto-generated). @bmorelli25 is there a good way to keep an eye on this as part of applying the designs you got from UX? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably being too picky because this is the first one. important things to note:
- add
applies
to all front matter (including for auto-migrated pages) - be careful with "deployments" language because these pages also possibly apply to serverless customers
|
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@shainaraskas : I've done a lot of updates here, I'll wait for your review:
|
…cloud_account_refinement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple more comments for you - very close to ready!!
@@ -1,18 +1,21 @@ | |||
--- | |||
mapped_pages: | |||
- https://www.elastic.co/guide/en/cloud/current/ec-update-email-address.html | |||
applies: | |||
serverless: all | |||
hosted: all | |||
--- | |||
|
|||
# Update your email address [ec-update-email-address] | |||
|
|||
Each Elasticsearch Service account has a primary email associated with it. By default, the primary email address is used to sign up for Elasticsearch Service and to log in. If needed, you can change this primary email address: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider splitting this into two child procedures with their own headings for scannability. not critical to do so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple more comments for you - very close to ready!!
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
committed to fix a couple of visual bugs and remove usage of "Elasticsearch Service". Good to go now! WOO FIRST TOP-LEVEL SECTION DONE
Cloud Account content reviewed and organized.
Overview added.
A few concerns (cc: @shainaraskas ):
In theory
cloud account
wasn't going to appear in the navigation menu. Should I update that also now?Would it make sense to put all the content of
join-and-leave-an-organization.md
directly atindex.md
instead of having it in a separate doc?Links: should we use relative paths starting with
../../..
or is it ok to use absolute links starting with/deploy-and-manage
for example?Important question: I have updated the
raw-migrated-files
that are being shared with other sections so the owners of the other sections are aware of the information that has been already used in theraw-migrated
file. Does that make sense or is it better if we don't touch them? I can discard those changes without issue, please review :)Closes https://github.com/elastic/docs-projects/issues/291
Closes https://github.com/elastic/docs-projects/issues/304