-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rule Tuning] December-January AWS Rule Tuning #4425
Conversation
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
@@ -53,6 +53,7 @@ This rule looks for the retrieval of credentials using `GetSecretValue` action i | |||
|
|||
### False positive analysis | |||
|
|||
- Review `user.id` values for expected ARNs. If this is an expected behavior, consider adding exceptions to the rule. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that while this is a relatively small change, we note why we are unable to tune the rule at this time in the tuning meta. As a result, we want to encourage user's to add exceptions on user.id
to reduce FPs.
index = ["filebeat-*", "logs-aws.cloudtrail-*"] | ||
language = "kuery" | ||
license = "Elastic License v2" | ||
name = "AWS EC2 User Data Retrieval for EC2 Instance" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a new rule, but renamed. logic adjusted and moved out of BBR.
index = ["filebeat-*", "logs-aws.cloudtrail-*"] | ||
language = "kuery" | ||
license = "Elastic License v2" | ||
name = "AWS EC2 Route Table Modified or Deleted" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a new rule, name and file name adjusted, investigation guide added and logic adjusted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Manual review, looks good to me! 👍
Pull Request
Issue link(s):
Summary - What I changed
This pull request tunes several AWS noisy rules based on telemetry from December 2024 --> January 2025.
For peer review - details regarding the tunings and context is available in the monthly AWS meta. However, I have summarized the rules and their respective tunings below.
AWS STS Temporary Credentials via AssumeRole
AWS Access Secret in Secrets Manager
AWS SSM SendCommand Execution by Rare User
AWS Systems Manager SecureString Parameter Request with Decryption Flag
AWS IAM Assume Role Policy Update
AWS EC2 User Data Retrieval for EC2 Instance
AWS EC2 Route Table Modified or Deleted
QoL Changes
How To Test
Checklist
bug
,enhancement
,schema
,maintenance
,Rule: New
,Rule: Deprecation
,Rule: Tuning
,Hunt: New
, orHunt: Tuning
so guidelines can be generatedmeta:rapid-merge
label if planning to merge within 24 hoursContributor checklist