Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ABS] Add concurrent_downloads option & archive check #333

Merged
merged 1 commit into from
Jan 17, 2023
Merged

[ABS] Add concurrent_downloads option & archive check #333

merged 1 commit into from
Jan 17, 2023

Conversation

parth-crest
Copy link
Collaborator

@parth-crest parth-crest commented Jan 17, 2023 •
edited
Loading

  1. Added tweak_bulk_options implementation as per Implement concurrent GCS reads #256 (comment) for tweaking concurrent_downloads to support adds concurency in lazy download #279
  2. Added archive tier check as it won't support permit download_blob operation
  3. Update configuration initialization in __init__ as per Fix configuration values sent to Kibana #287

Checklists

Pre-Review Checklist

  • Covered the changes with automated tests
  • Tested the changes locally

@moxarth-elastic
Copy link
Collaborator

buildkite test this

@parth-crest parth-crest marked this pull request as ready for review January 17, 2023 13:02
@tarekziade tarekziade merged commit 0a2821f into elastic:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarekziade tarekziade tarekziade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parth-crest @moxarth-elastic @tarekziade