Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Autoscalers are not yet supported by Logstash on ECK #7821

Merged
merged 2 commits into from
May 17, 2024
Merged

Doc: Autoscalers are not yet supported by Logstash on ECK #7821

merged 2 commits into from
May 17, 2024

Conversation

karenzone
Copy link
Contributor

@karenzone karenzone commented May 16, 2024 •
edited
Loading

@karenzone karenzone added the >docs Documentation label May 16, 2024
@karenzone karenzone self-assigned this May 16, 2024
@karenzone karenzone requested a review from robbavey May 16, 2024 20:26
@kvalliyurnatt
Copy link
Contributor

kvalliyurnatt commented May 16, 2024 •
edited
Loading

@karenzone is this needed for the upcoming release ? (2.13.0 that is scheduled for May21)

@karenzone
Copy link
Contributor Author

@karenzone is this needed for the upcoming release ? (2.13.0 that is scheduled for May21)

As this is just a note, I would think maybe not. But I'll defer to @robbavey. Rob, what do you think?

@robbavey
Copy link
Member

@kvesthy We would prefer this to be in there, but if there are higher priority items that would prevent that, it could be added later

robbavey
robbavey approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karenzone
Copy link
Contributor Author

@kvesthy, Rob has approved it, and I just merged main back into my branch. We'll need an approval and merge by an ECK codeowner, and we'll be ready to go!

barkbay
barkbay approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karenzone is this needed for the upcoming release ? (2.13.0 that is scheduled for May21)

I think we can backport doc changes as soon as we think it is necessary. We could include this change in 2.13, and also do a backport into 2.12 immediately.

@barkbay
Copy link
Contributor

barkbay commented May 17, 2024

s / @kvesthy / @kvalliyurnatt , so many Karthik at Elastic 😄

@barkbay barkbay merged commit c1c0a1e into elastic:main May 17, 2024
5 checks passed
@kvalliyurnatt
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 2.13

Questions ?

Please refer to the Backport tool documentation

kvalliyurnatt pushed a commit to kvalliyurnatt/cloud-on-k8s that referenced this pull request May 17, 2024
@karenzone
Doc: Add note that autoscalers are not yet supported with Logstash on…
523554f 
… ECK (elastic#7821)

(cherry picked from commit c1c0a1e)
@kvalliyurnatt kvalliyurnatt mentioned this pull request May 17, 2024
Merged
kvalliyurnatt added a commit that referenced this pull request May 17, 2024
@kvalliyurnatt @karenzone
Doc: Add note that autoscalers are not yet supported with Logstash on…
5c9311b 
… ECK (#7821) (#7826)

(cherry picked from commit c1c0a1e)

Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
@karenzone karenzone deleted the 7820-note-about-autoscalers branch May 21, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbavey robbavey robbavey approved these changes

@barkbay barkbay barkbay approved these changes

Assignees

@karenzone karenzone

Labels
>docs Documentation v2.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doc: Add messaging about autoscaling for Logstash on ECK
4 participants
@karenzone @kvalliyurnatt @robbavey @barkbay